Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic configuration of vschema acl #17333

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Dec 4, 2024

This allows configuring the users for the vschema dynamically at runtime so you don't need to restart vtgate if this changes.

Related Issue(s)

Fixes #17350

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Dec 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 4, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 4, 2024
@harshit-gangal harshit-gangal force-pushed the dbussink/allow-dynamic-vschema-authorized-users branch from 98084d9 to da25eac Compare December 4, 2024 15:27
@dbussink dbussink force-pushed the dbussink/allow-dynamic-vschema-authorized-users branch from da25eac to 98084d9 Compare December 4, 2024 15:50
@harshit-gangal harshit-gangal force-pushed the dbussink/allow-dynamic-vschema-authorized-users branch from 98084d9 to da25eac Compare December 4, 2024 15:53
@dbussink dbussink force-pushed the dbussink/allow-dynamic-vschema-authorized-users branch from da25eac to 98084d9 Compare December 4, 2024 15:55
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (f746c48) to head (935e5f6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/vschemaacl/vschemaacl.go 90.90% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17333   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files        1577     1577           
  Lines      253420   253458   +38     
=======================================
+ Hits       171022   171053   +31     
- Misses      82398    82405    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 9, 2024
This allows configuring the users for the vschema dynamically at runtime
so you don't need to restart vtgate if this changes.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/allow-dynamic-vschema-authorized-users branch from 98084d9 to c84400f Compare December 9, 2024 15:12
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit-gangal harshit-gangal merged commit 0fe256e into vitessio:main Dec 10, 2024
100 checks passed
@harshit-gangal harshit-gangal deleted the dbussink/allow-dynamic-vschema-authorized-users branch December 10, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow configuring the vtgate VSchema ACL settings dynamically
3 participants