-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamic configuration of vschema acl #17333
Allow dynamic configuration of vschema acl #17333
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
98084d9
to
da25eac
Compare
da25eac
to
98084d9
Compare
98084d9
to
da25eac
Compare
da25eac
to
98084d9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17333 +/- ##
=======================================
Coverage 67.48% 67.48%
=======================================
Files 1577 1577
Lines 253420 253458 +38
=======================================
+ Hits 171022 171053 +31
- Misses 82398 82405 +7 ☔ View full report in Codecov by Sentry. |
This allows configuring the users for the vschema dynamically at runtime so you don't need to restart vtgate if this changes. Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
98084d9
to
c84400f
Compare
Signed-off-by: Dirkjan Bussink <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This allows configuring the users for the vschema dynamically at runtime so you don't need to restart vtgate if this changes.
Related Issue(s)
Fixes #17350
Checklist