Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Bump to v19.0.9-SNAPSHOT after the v19.0.8 release #17321

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[release-19.0] Bump to v19.0.9-SNAPSHOT after the v19.0.8 release #17321

merged 1 commit into from
Dec 4, 2024

Conversation

vitess-bot
Copy link
Contributor

Includes the changes required to go back into dev mode (v19.0.9-SNAPSHOT) after the release of v19.0.8.

@rohit-nayak-ps
Back to dev mode: [release-19.0] Bump to v19.0.9-SNAPSHOT after the…
c7df2ba 
… `v19.0.8` release

This commit was made automatically by the vitess-releaser tool.

See https://github.com/vitessio/vitess-releaser

Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot requested a review from deepthi as a code owner December 3, 2024 05:06
@vitess-bot vitess-bot added Component: General Changes throughout the code base Type: Release labels Dec 3, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 3, 2024
@vitess-bot vitess-bot mentioned this pull request Dec 3, 2024
Closed
28 tasks
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.17%. Comparing base (2665aa2) to head (c7df2ba).
Report is 1 commits behind head on release-19.0.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-19.0   #17321      +/-   ##
================================================
- Coverage         65.18%   65.17%   -0.01%     
================================================
  Files              1560     1560              
  Lines            238305   238305              
================================================
- Hits             155329   155322       -7     
- Misses            82976    82983       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui added this to the v19.0.9 milestone Dec 4, 2024
@frouioui
Copy link
Member

frouioui commented Dec 4, 2024

Assign Milestone failure can be ignored.

@deepthi deepthi merged commit d6ee896 into release-19.0 Dec 4, 2024
212 of 213 checks passed
@deepthi deepthi deleted the release-19.0-back-to-dev-mode-2 branch December 4, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Release
Projects
None yet
Milestone
v19.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@vitess-bot @frouioui @deepthi @rohit-nayak-ps