-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool to determine mapping from vindex and value to shard #17290
Changes from 6 commits
7de1507
0ad3578
03ec401
772bf39
3af6cc8
201a033
ad73582
9937aa8
1ad2d64
98ee23c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Copyright 2024 The Vitess Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
build: | ||
go build map-shard-for-value.go | ||
|
||
test: | ||
echo "1\n-1\n99" | go run map-shard-for-value.go --total_shards=4 --vindex=xxhash | ||
|
||
clean: | ||
rm -f map-shard-for-value |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,194 @@ | ||
/* | ||
Copyright 2024 The Vitess Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package main | ||
|
||
import ( | ||
"bufio" | ||
"context" | ||
"encoding/hex" | ||
"fmt" | ||
"log" | ||
"os" | ||
"strconv" | ||
"strings" | ||
|
||
flag "github.com/spf13/pflag" | ||
|
||
"vitess.io/vitess/go/sqltypes" | ||
"vitess.io/vitess/go/vt/key" | ||
"vitess.io/vitess/go/vt/proto/topodata" | ||
"vitess.io/vitess/go/vt/vtgate/vindexes" | ||
) | ||
|
||
/* | ||
* This tool reads a list of values from stdin and prints the | ||
* corresponding keyspace ID and shard for each value. It uses the given vindex | ||
* and shard ranges to determine the shard. The vindex is expected to be a | ||
* single-column vindex. The shard ranges are specified as a comma-separated | ||
* list of key ranges, example "-80,80-". | ||
* If you have uniformly distributed shards, you can specify the total number | ||
* of shards using the -total_shards flag, and the tool will generate the shard ranges | ||
* using the same logic as the Vitess operator does (using the key.GenerateShardRanges() function). | ||
* | ||
* Example usage: | ||
* echo "1\n2\n3" | go run shard-from-id.go -vindex=hash -shards=-80,80- | ||
* | ||
* Currently tested only for integer values and hash/xxhash vindexes. | ||
*/ | ||
|
||
func mapShard(shards map[string]*topodata.KeyRange, ksid key.DestinationKeyspaceID) (string, error) { | ||
foundShard := "" | ||
addShard := func(shard string) error { | ||
foundShard = shard | ||
return nil | ||
} | ||
allShards := make([]*topodata.ShardReference, 0, len(shards)) | ||
for shard, keyRange := range shards { | ||
allShards = append(allShards, &topodata.ShardReference{ | ||
Name: shard, | ||
KeyRange: keyRange, | ||
}) | ||
} | ||
if err := ksid.Resolve(allShards, addShard); err != nil { | ||
return "", fmt.Errorf("failed to resolve keyspace ID: %v:: %s", ksid.String(), err) | ||
} | ||
|
||
if foundShard == "" { | ||
return "", fmt.Errorf("no shard found for keyspace ID: %v", ksid) | ||
} | ||
return foundShard, nil | ||
} | ||
|
||
func selectShard(vindex vindexes.Vindex, value sqltypes.Value, shards map[string]*topodata.KeyRange) (string, key.DestinationKeyspaceID, error) { | ||
ctx := context.Background() | ||
|
||
destinations, err := vindexes.Map(ctx, vindex, nil, [][]sqltypes.Value{{value}}) | ||
if err != nil { | ||
return "", nil, fmt.Errorf("failed to map value to keyspace ID: %w", err) | ||
} | ||
|
||
if len(destinations) != 1 { | ||
return "", nil, fmt.Errorf("unexpected number of destinations: %d", len(destinations)) | ||
} | ||
|
||
ksid, ok := destinations[0].(key.DestinationKeyspaceID) | ||
if !ok { | ||
return "", nil, fmt.Errorf("unexpected destination type: %T", destinations[0]) | ||
} | ||
|
||
foundShard, err := mapShard(shards, ksid) | ||
if err != nil { | ||
return "", nil, fmt.Errorf("failed to map shard: %w", err) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should add the original value as well to the error message There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
return foundShard, ksid, nil | ||
} | ||
|
||
func getValue(valueStr string) (sqltypes.Value, int64, error) { | ||
var value sqltypes.Value | ||
valueInt, err := strconv.ParseInt(valueStr, 10, 64) | ||
if err == nil { | ||
value = sqltypes.NewInt64(int64(valueInt)) | ||
} else { | ||
valueUint, err := strconv.ParseUint(valueStr, 10, 64) | ||
if err == nil { | ||
value = sqltypes.NewUint64(valueUint) | ||
} else { | ||
value = sqltypes.NewVarChar(valueStr) | ||
} | ||
} | ||
return value, valueInt, err | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should take value type as input using cli There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
func getShardMap(shardsCSV *string) map[string]*topodata.KeyRange { | ||
shards := make(map[string]*topodata.KeyRange) | ||
var err error | ||
for _, shard := range strings.Split(*shardsCSV, ",") { | ||
parts := strings.Split(shard, "-") | ||
var start, end []byte | ||
if len(parts) > 0 && parts[0] != "" { | ||
start, err = hex.DecodeString(parts[0]) | ||
if err != nil { | ||
log.Fatalf("failed to decode shard start: %v", err) | ||
} | ||
} | ||
if len(parts) > 1 && parts[1] != "" { | ||
end, err = hex.DecodeString(parts[1]) | ||
if err != nil { | ||
log.Fatalf("failed to decode shard end: %v", err) | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can use method There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can also look at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Used |
||
shards[shard] = &topodata.KeyRange{Start: start, End: end} | ||
} | ||
return shards | ||
} | ||
|
||
func main() { | ||
vindexName := flag.String("vindex", "xxhash", "name of the vindex") | ||
shardsCSV := flag.String("shards", "", "comma-separated list of shard ranges") | ||
totalShards := flag.Int("total_shards", 0, "total number of uniformly distributed shards") | ||
flag.Parse() | ||
|
||
if *totalShards > 0 { | ||
if *shardsCSV != "" { | ||
log.Fatalf("cannot specify both total_shards and shards") | ||
} | ||
shardArr, err := key.GenerateShardRanges(*totalShards) | ||
if err != nil { | ||
log.Fatalf("failed to generate shard ranges: %v", err) | ||
} | ||
*shardsCSV = strings.Join(shardArr, ",") | ||
} | ||
if *shardsCSV == "" { | ||
log.Fatal("shards or total_shards must be specified") | ||
} | ||
|
||
shards := getShardMap(shardsCSV) | ||
|
||
vindex, err := vindexes.CreateVindex(*vindexName, *vindexName, nil) | ||
if err != nil { | ||
log.Fatalf("failed to create vindex: %v", err) | ||
} | ||
|
||
scanner := bufio.NewScanner(os.Stdin) | ||
first := true | ||
for scanner.Scan() { | ||
valueStr := scanner.Text() | ||
if valueStr == "" { | ||
continue | ||
} | ||
value, _, err := getValue(valueStr) | ||
|
||
shard, ksid, err := selectShard(vindex, value, shards) | ||
if err != nil { | ||
// ignore errors so that we can go ahead with the computation for other values | ||
continue | ||
} | ||
|
||
if first { | ||
// print header | ||
fmt.Println("value,keyspaceID,shard") | ||
first = false | ||
} | ||
|
||
ksidStr := hex.EncodeToString([]byte(ksid)) | ||
fmt.Printf("%s,%s,%s\n", valueStr, ksidStr, shard) | ||
} | ||
|
||
if err := scanner.Err(); err != nil { | ||
log.Fatalf("error reading from stdin: %v", err) | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
## Map Shard for Value Tool | ||
|
||
### Overview | ||
|
||
The `map-shard-for-value` tool maps a given value to a specific shard. This tool helps in determining | ||
which shard a particular value belongs to, based on the vindex algorithm and shard ranges. | ||
|
||
### Features | ||
- | ||
|
||
- Allows specifying the vindex type (e.g., `hash`, `xxhash`). | ||
- Allows specifying the shard list of (for uniformly distributed shard ranges) the total number of shards to generate. | ||
- Designed as a _filter_: Reads input values from `stdin` and outputs the corresponding shard information, so it can be | ||
used to map values from a file or another program. | ||
|
||
### Usage | ||
|
||
```sh | ||
make build | ||
``` | ||
|
||
```sh | ||
echo "1\n-1\n99" | ./map-shard-for-value --total_shards=4 --vindex=xxhash | ||
value,keyspaceID,shard | ||
1,d46405367612b4b7,c0- | ||
-1,d8e2a6a7c8c7623d,c0- | ||
99,200533312244abca,-40 | ||
|
||
echo "1\n-1\n99" | ./map-shard-for-value --vindex=hash --shards="-80,80-" | ||
value,keyspaceID,shard | ||
1,166b40b44aba4bd6,-80 | ||
-1,355550b2150e2451,-80 | ||
99,2c40ad56f4593c47,-80 | ||
``` | ||
|
||
#### Flags | ||
|
||
- `--vindex`: Specifies the name of the vindex to use (e.g., `hash`, `xxhash`) (default `xxhash`) | ||
|
||
One (and only one) of these is required: | ||
|
||
- `--shards`: Comma-separated list of shard ranges | ||
- `--total_shards`: Total number of shards, only if shards are uniformly distributed | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be done as part of a struct init and passed along to methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done