Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Specify Ubuntu 24.04 for all jobs (#17278) #17280

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Nov 25, 2024

Description

This is a backport of #17278

@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI Merge Conflict Skip CI Skip CI actions from running Type: CI/Build labels Nov 25, 2024
Copy link
Contributor Author

vitess-bot bot commented Nov 25, 2024

Hello @dbussink, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 17280 -R vitessio/vitess
git reset --hard origin/release-19.0
git cherry-pick -m 1 145ff6b09e223e4fd89eaf4813be81ec46d04b2e

Copy link
Contributor Author

vitess-bot bot commented Nov 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.16%. Comparing base (36a3f9e) to head (2c7b313).
Report is 2 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17280      +/-   ##
================================================
+ Coverage         65.14%   65.16%   +0.02%     
================================================
  Files              1560     1560              
  Lines            238305   238305              
================================================
+ Hits             155255   155303      +48     
+ Misses            83050    83002      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink removed Skip CI Skip CI actions from running Merge Conflict labels Nov 25, 2024
@dbussink dbussink marked this pull request as ready for review November 25, 2024 20:42
@dbussink dbussink force-pushed the backport-17278-to-release-19.0 branch 3 times, most recently from c849715 to 1e797b6 Compare November 25, 2024 20:52
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the backport-17278-to-release-19.0 branch from 1e797b6 to 36c2e8a Compare November 25, 2024 21:02
@rohit-nayak-ps rohit-nayak-ps merged commit 1fe9557 into release-19.0 Nov 26, 2024
204 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the backport-17278-to-release-19.0 branch November 26, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants