Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Server.LookupVindexCreate #17242

Merged
merged 17 commits into from
Dec 22, 2024

refac: newLookupVindex func to reduce code duplicacy

94dfd64
Select commit
Loading
Failed to load commit list.
Merged

Refactor Server.LookupVindexCreate #17242

refac: newLookupVindex func to reduce code duplicacy
94dfd64
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 21, 2024 in 0s

67.64% (+0.12%) compared to 45192d2

View this Pull Request on Codecov

67.64% (+0.12%) compared to 45192d2

Details

Codecov Report

Attention: Patch coverage is 87.59305% with 50 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (45192d2) to head (94dfd64).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/lookup_vindex.go 88.49% 45 Missing ⚠️
go/vt/vtctl/workflow/server.go 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17242      +/-   ##
==========================================
+ Coverage   67.52%   67.64%   +0.12%     
==========================================
  Files        1581     1583       +2     
  Lines      253948   254043      +95     
==========================================
+ Hits       171480   171854     +374     
+ Misses      82468    82189     -279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.