Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Close zookeeper topo connection on disconnect (#17136) #17191

Merged
merged 1 commit into from
Nov 9, 2024

Close zookeeper topo connection on disconnect (#17136)

e96822d
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Close zookeeper topo connection on disconnect (#17136) #17191

Close zookeeper topo connection on disconnect (#17136)
e96822d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2024 in 0s

65.14% (-0.01%) compared to dc9c65e, passed because coverage increased by 0% when compared to adjusted base (65.14%)

View this Pull Request on Codecov

65.14% (-0.01%) compared to dc9c65e, passed because coverage increased by 0% when compared to adjusted base (65.14%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.14%. Comparing base (dc9c65e) to head (e96822d).

Files with missing lines Patch % Lines
go/vt/topo/zk2topo/zk_conn.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17191      +/-   ##
================================================
- Coverage         65.14%   65.14%   -0.01%     
================================================
  Files              1560     1560              
  Lines            238219   238215       -4     
================================================
- Hits             155189   155182       -7     
- Misses            83030    83033       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.