Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTAdmin: Support for multiple DataTable accessing same URL #17036

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

beingnoble03
Copy link
Member

Description

DataTable(s) on workflow details tab have broken pagination. Every DataTable accessed the same query parameter from URL i.e. page to set and retrieve the current page number of DataTable. It was implemented in such a way that only a single DataTable should access the URL parameters at a time.

This PR fixes this issue by customising the URL parameter used by each DataTable. While using multiple DataTable in a component, pass on an optional unique prop pageKey if we expect multiple DataTable using the same URL. Each DataTable will use a query parameter for fetching/modifying the page number based on it's own unique passed prop pageKey.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Oct 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 22, 2024
@beingnoble03 beingnoble03 changed the title fix: Support for multiple DataTable accessing same URL VTAdmin: Support for multiple DataTable accessing same URL Oct 22, 2024
@beingnoble03 beingnoble03 added Type: Bug Component: VTAdmin VTadmin interface and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 22, 2024
Signed-off-by: Noble Mittal <[email protected]>
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 22, 2024
@beingnoble03 beingnoble03 marked this pull request as ready for review October 22, 2024 14:09
@rohit-nayak-ps rohit-nayak-ps merged commit 0eb27b2 into vitessio:main Nov 8, 2024
99 checks passed
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants