Relax vexplain test for upcoming changes #17035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
requested review from
harshit-gangal,
systay and
frouioui
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
dbussink
added
Component: Query Serving
Type: Testing
and removed
NeedsDescriptionUpdate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #17035 +/- ##
=============================================
Coverage 67.21% 67.21%
=============================================
Files 1570 1570
Lines 251256 251256
=============================================
+ Hits 168885 168890 +5
+ Misses 82371 82366 -5 ☔ View full report in Codecov by Sentry. |
The fix in vitessio#16988 makes a change here that's not really a breaking change, but it does break the test as the test matches the exact string output which changes here due to a binary value. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
dbussink/relax-vexplain-test
branch
from
406e763 to
564cf1a
Compare
GuptaManan100
approved these changes
Oct 22, 2024
| @@ -53,6 +53,7 @@ func start(t *testing.T) (*mysql.Conn, func()) { | |||
| } | |||
|
|
|||
| func TestVtGateVExplain(t *testing.T) { | |||
| t.Skip("v22 changes the output of vexplain queries because of binary bind vars which breaks this test.") | |||
There was a problem hiding this comment.
This is fine too, but we can also only skip for v22 version of vtgate.
There was a problem hiding this comment.
I plan to clean this up / improve this once I have #16988 landed on main.
Signed-off-by: Dirkjan Bussink <[email protected]>
rohit-nayak-ps
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #16988 makes a change here that's not really a breaking change, but it does break the test as the test matches the exact string output which changes here due to a binary value.
Related Issue(s)
Needed for #16988 which is a fix for #16989.
Checklist