-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Direct PR] [release-21.0] Augment PrimaryStatus
to also send Server UUID
#17032
Merged
rohit-nayak-ps
merged 1 commit into
vitessio:release-21.0
from
planetscale:rpc-primary-status
Oct 22, 2024
Merged
[Direct PR] [release-21.0] Augment PrimaryStatus
to also send Server UUID
#17032
rohit-nayak-ps
merged 1 commit into
vitessio:release-21.0
from
planetscale:rpc-primary-status
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Cluster management
labels
Oct 22, 2024
GuptaManan100
requested review from
deepthi,
harshit-gangal,
mattlord and
systay
as code owners
October 22, 2024 07:18
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 22, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 22, 2024
deepthi
approved these changes
Oct 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #17032 +/- ##
================================================
- Coverage 67.23% 67.22% -0.02%
================================================
Files 1570 1570
Lines 251247 251256 +9
================================================
- Hits 168938 168913 -25
- Misses 82309 82343 +34 ☔ View full report in Codecov by Sentry. |
shlomi-noach
approved these changes
Oct 22, 2024
rohit-nayak-ps
merged commit Oct 22, 2024
1a3b5a1
into
vitessio:release-21.0
112 of 113 checks passed
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Cluster management
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the RPC changes that are required for #17031 to work as intended.
Related Issue(s)
Checklist
Deployment Notes