Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakiness in TestListenerShutdown #17024

Merged

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 21, 2024

Description

This is a follow up of #16940 where the test was modified to alleviate flakiness.

This PR aims at removing (or at least reducing) the flakiness observed on TestListenerShutdown. This test almost never fails on this repository's CI, but I have observed several failures in other repositories where the CI is less beefy. The original error was:

--- FAIL: TestListenerShutdown (10.00s)
    server_test.go:265: listening on address '127.0.0.1' port 41183
    server_test.go:1448: 
        	Error Trace:	/opt/actions-runner/_work/vitess-private/vitess-private/go/mysql/server_test.go:1448
        	            				/opt/actions-runner/_work/vitess-private/vitess-private/go/mysql/server_test.go:1427
        	Error:      	connRefuse did not reach %v
        	Test:       	TestListenerShutdown
        	Messages:   	1
FAIL
FAIL	vitess.io/vitess/go/mysql	39.529s

I ran this fix ten times in another repository where the issue was first observed, and it passed successfully the ten times.
image

Copy link
Contributor

vitess-bot bot commented Oct 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 21, 2024
@frouioui frouioui added Component: Cluster management Type: CI/Build Flakes and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 21, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 21, 2024
@frouioui frouioui added Backport to: release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (9c9a893) to head (e19acbc).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17024      +/-   ##
==========================================
- Coverage   67.17%   67.16%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      252249   252249              
==========================================
- Hits       169459   169434      -25     
- Misses      82790    82815      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Florent Poinsard <[email protected]>
This was referenced Oct 21, 2024
@frouioui frouioui requested a review from deepthi October 30, 2024 19:10
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vitess-bot vitess-bot mentioned this pull request Nov 5, 2024
30 tasks
@vitess-bot vitess-bot mentioned this pull request Nov 5, 2024
29 tasks
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@deepthi deepthi merged commit 2d1e96a into vitessio:main Nov 8, 2024
98 checks passed
@deepthi deepthi deleted the fix-TestListenerShutdown-flakiness branch November 8, 2024 19:52
frouioui added a commit that referenced this pull request Nov 19, 2024
frouioui added a commit that referenced this pull request Nov 19, 2024
frouioui added a commit that referenced this pull request Nov 19, 2024
rvrangel pushed a commit to rvrangel/vitess that referenced this pull request Nov 21, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Renan Rangel <[email protected]>
deepthi pushed a commit that referenced this pull request Nov 25, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
deepthi pushed a commit that referenced this pull request Nov 25, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
deepthi pushed a commit that referenced this pull request Nov 25, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: Cluster management Flakes Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants