CI: Correct etcd and ncurses package names for Ubuntu 24.04

[mattlord]

Description

In Ubuntu 24.04 — which is currently what is used for ubuntu-latest in GitHub Actions — the etcd package was split into etcd-client and etcd-server and it includes libncurses6.

Note

This is not needed today (the driver for opening this seems to have been fixed in Actions) — so there must be package helpers in 24.04 that help bridge the gap and cover the transition, but these may go away in 26.04. Since these are the correct package names, there's no reason not to make the change.

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[GrahamCampbell]

Might it be prudent to pin to ubuntu-22.04, rather than latest (in particular for the versions older than Vitess 22), so things don't break from under us?

[mattlord]

Might it be prudent to pin to ubuntu-22.04, rather than latest (in particular for the versions older than Vitess 22), so things don't break from under us?

Yeah, it looks like we'll probably need to do that.

[GrahamCampbell]

Yeah, it looks like we'll probably need to do that.

Or at least, pin to 24.04, so the next upgrade to 26.04 will be explicit (and backport optional).

[dbussink]

Might it be prudent to pin to ubuntu-22.04, rather than latest (in particular for the versions older than Vitess 22), so things don't break from under us?

We had everything pinned, but that was changed in #16714. @frouioui Was that done out of necessity there? I know we pinned it explicitly before to avoid upgrade problems.