Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] fixes bugs around expression precedence and LIKE (#16934 & #16649) #16946

Merged
merged 2 commits into from
Oct 15, 2024

Fix Precedence rule for Tilda op (#16649)

0e795c7
Select commit
Loading
Failed to load commit list.
Merged

[release-20.0] fixes bugs around expression precedence and LIKE (#16934 & #16649) #16946

Fix Precedence rule for Tilda op (#16649)
0e795c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 15, 2024 in 1s

68.69% (+0.02%) compared to d744b20

View this Pull Request on Codecov

68.69% (+0.02%) compared to d744b20

Details

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (d744b20) to head (0e795c7).

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/fn_string.go 91.66% 1 Missing ⚠️
go/vt/vtgate/evalengine/translate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16946      +/-   ##
================================================
+ Coverage         68.66%   68.69%   +0.02%     
================================================
  Files              1541     1541              
  Lines            197984   197971      -13     
================================================
+ Hits             135952   135997      +45     
+ Misses            62032    61974      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.