Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Support reversing read-only traffic in vtctldclient #16920

Merged
merged 32 commits into from
Oct 20, 2024

Minor changes after final self review

e9685d5
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Support reversing read-only traffic in vtctldclient #16920

Minor changes after final self review
e9685d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 20, 2024 in 1s

67.15% (-2.20%) compared to 4e89152

View this Pull Request on Codecov

67.15% (-2.20%) compared to 4e89152

Details

Codecov Report

Attention: Patch coverage is 59.74026% with 31 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (4e89152) to head (e9685d5).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/server.go 59.25% 22 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 60.86% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16920      +/-   ##
==========================================
- Coverage   69.35%   67.15%   -2.20%     
==========================================
  Files        1571     1571              
  Lines      204149   251785   +47636     
==========================================
+ Hits       141583   169087   +27504     
- Misses      62566    82698   +20132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.