-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTAdmin: Add support for Create Reshard #16903
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <[email protected]>
0656c9a
to
245994c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16903 +/- ##
==========================================
- Coverage 69.43% 69.40% -0.03%
==========================================
Files 1570 1570
Lines 203812 203871 +59
==========================================
- Hits 141517 141499 -18
- Misses 62295 62372 +77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the UI
- Move source shards to row below so the shards are next to each other
- Change label "Source Keyspace" => "Keyspace" since there is just one keyspace
Rest looks good
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I tested it locally on the PR branch with:
make build
cd examples/local
./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql; ./201_customer_tablets.sh; ./202_move_tables.sh; ./203_switch_reads.sh; ./204_switch_writes.sh; ./205_clean_commerce.sh; ./301_customer_sharded.sh; ./302_new_shards.sh
Then in VTAdmin creating a Reshard workflow from the 0 shard to the -80,80- shards (what the ./303_reshard.sh script does).
Thanks! ❤️
Description
This PR adds support to create a reshard workflow directly from VTAdmin. Contains both API and Web changes.
Related Issue(s)
Screenshots
Checklist
Deployment Notes