Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced output for vexplain keys #16892

Merged
merged 6 commits into from
Oct 7, 2024

clean up json marshalling

5bccc70
Select commit
Loading
Failed to load commit list.
Merged

Enhanced output for vexplain keys #16892

clean up json marshalling
5bccc70
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 1s

69.44% (+0.01%) compared to eab262e

View this Pull Request on Codecov

69.44% (+0.01%) compared to eab262e

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 60 lines in your changes missing coverage. Please review.

Project coverage is 69.44%. Comparing base (eab262e) to head (5bccc70).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/sqlparser/ast_funcs.go 43.01% 53 Missing ⚠️
go/vt/vtgate/planbuilder/operators/keys.go 91.95% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16892      +/-   ##
==========================================
+ Coverage   69.42%   69.44%   +0.01%     
==========================================
  Files        1571     1570       -1     
  Lines      203276   203606     +330     
==========================================
+ Hits       141125   141393     +268     
- Misses      62151    62213      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.