-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTAdmin(web): Add refresh compatibility to workflow screen (all tabs) #16865
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested it out locally this way using the PR branch:
cd examples/local
alias vtctldclient='command vtctldclient --server=localhost:15999'
./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql; ./201_customer_tablets.sh; ./202_move_tables.sh
Then I made changes to the workflow directly using vtctldclient
and I could see the changes reflected in the UI on refresh (including new workflows).
Description
This PR adds refresh compatibility providing the user functionality to enable auto refresh workflow status after some selectable intervals (10s, 30s, 1m, 10m or Never.) Also, removes the redundant "Scroll to streams" link from all workflow pages. This PR is a follow-up to #16706.
Related Issue(s)
Screenshots
Checklist
Deployment Notes