VTAdmin: Support for conclude txn and abandon age param

[beingnoble03]

Description

• Adds support for conclude transaction in VTAdmin.
• Adds an optional dropdown for selecting abandonAge, if it's empty, we use the default abandon age.
• The dropdown carries the following options: 5sec, 30sec, 1min, 5min, 15min and 1hr.

Related Issue(s)

• Feature Request: Distributed Transaction Actions on VTAdmin  #16766

Screenshots

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (f40e076) to head (a8bea60).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtadmin/api.go	6.66%	14 Missing ⚠️
go/vt/vtadmin/http/transactions.go	0.00%	12 Missing ⚠️
go/vt/vtadmin/http/request.go	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16834      +/-   ##
==========================================
- Coverage   69.43%   69.41%   -0.03%     
==========================================
  Files        1570     1570              
  Lines      203812   203846      +34     
==========================================
- Hits       141517   141496      -21     
- Misses      62295    62350      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[beingnoble03]

typo :)

[notfelineit]

Perhaps this would be better as a:

if !api.authz.IsAuthorized(ctx, c.ID, rbac.ClusterResource, rbac.GetAction) {
    return nil, nil
}

Before fetching the cluster on line 539 instead!

[beingnoble03]

Done.

[notfelineit]

🥳

[notfelineit]

Why wouldn't you want to update on params clusterID and keyspace changing too?

[beingnoble03]

Already using params (which is a stateful value, contains keyspace, clusterID and abandonAge) while fetching transactions.

    const transactionsQuery = useTransactions(params, {
        enabled: !!params.keyspace,
    });

Infact, we don't even need useEffect here. 😃 Removing it.

[harshit-gangal]

Sorry this fall off my radar.
We should keep the default set for Abandon Age to 15 mins here.