Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid creating MoveTables in case of non-empty target tables #16826

Closed
wants to merge 3 commits into from

test: Mock query for failing tests

8393dea
Select commit
Loading
Failed to load commit list.
Closed

fix: Avoid creating MoveTables in case of non-empty target tables #16826

test: Mock query for failing tests
8393dea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2024 in 0s

69.45% (-0.06%) compared to 95f2e3e

View this Pull Request on Codecov

69.45% (-0.06%) compared to 95f2e3e

Details

Codecov Report

Attention: Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (95f2e3e) to head (8393dea).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/utils.go 85.71% 6 Missing ⚠️
go/vt/vtctl/workflow/materializer.go 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16826      +/-   ##
==========================================
- Coverage   69.51%   69.45%   -0.06%     
==========================================
  Files        1569     1571       +2     
  Lines      202517   203121     +604     
==========================================
+ Hits       140780   141083     +303     
- Misses      61737    62038     +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.