Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes for docker-compose setup #16818

Merged
merged 1 commit into from
Sep 24, 2024
Merged

small fixes for docker-compose setup #16818

merged 1 commit into from
Sep 24, 2024

Conversation

perminov
Copy link
Contributor

examples/compose/

  • docker-compose.beginners.yml: fixed depends_on declarations for vtctld and vtgate services
  • README.md: added ' -a' for 'docker-compose ps' for it to match the example output
  • vttablet-up.sh: added 's' as units for '--queryserver-config-schema-reload-time 60'

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 22, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 22, 2024
@mattlord mattlord added Component: Examples Type: Bug and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 22, 2024
mattlord
mattlord approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @perminov !

@mattlord
Copy link
Contributor

@perminov one thing that we'll need you to address before we can merge is the failed DCO check: https://github.com/vitessio/vitess/pull/16818/checks?check_run_id=30480730370

@perminov
examples/compose/
3d5d4c9 
 - docker-compose.beginners.yml: fixed depends_on declarations for vtctld and vtgate services
 - README.md: added ' -a' for 'docker-compose ps' for it to match the example output
 - vttablet-up.sh: added 's' as units for '--queryserver-config-schema-reload-time 60'

Signed-off-by: Pavel Perminov <[email protected]>
@mattlord mattlord merged commit 72d5ea4 into vitessio:main Sep 24, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Examples Type: Bug
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@perminov @mattlord @frouioui