Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes on Distributed Transaction user apis #16788

Merged
merged 11 commits into from
Sep 23, 2024

Merge remote-tracking branch 'upstream/main' into unresolved-tx-age

f708ce8
Select commit
Loading
Failed to load commit list.
Merged

Multiple changes on Distributed Transaction user apis #16788

Merge remote-tracking branch 'upstream/main' into unresolved-tx-age
f708ce8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 23, 2024 in 0s

69.53% (+0.01%) compared to 9563fcb

View this Pull Request on Codecov

69.53% (+0.01%) compared to 9563fcb

Details

Codecov Report

Attention: Patch coverage is 80.39216% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (9563fcb) to head (f708ce8).

Files with missing lines Patch % Lines
go/cmd/vtctldclient/command/transactions.go 37.50% 5 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 4 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_transaction.go 85.00% 3 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 0.00% 2 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 83.33% 1 Missing ⚠️
go/vt/vtgate/tx_conn.go 50.00% 1 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 90.90% 1 Missing ⚠️
go/vt/vttablet/grpctmserver/server.go 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16788      +/-   ##
==========================================
+ Coverage   69.52%   69.53%   +0.01%     
==========================================
  Files        1568     1569       +1     
  Lines      202442   202492      +50     
==========================================
+ Hits       140741   140804      +63     
+ Misses      61701    61688      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov