Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialize workflow support for reference tables #16787

Merged
merged 14 commits into from
Sep 24, 2024

Address review comment

8af9387
Select commit
Loading
Failed to load commit list.
Merged

Materialize workflow support for reference tables #16787

Address review comment
8af9387
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 0s

69.50% (-0.02%) compared to 95f2e3e

View this Pull Request on Codecov

69.50% (-0.02%) compared to 95f2e3e

Details

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.50%. Comparing base (95f2e3e) to head (8af9387).

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/server.go 18.18% 9 Missing ⚠️
...dclient/command/vreplication/materialize/create.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16787      +/-   ##
==========================================
- Coverage   69.51%   69.50%   -0.02%     
==========================================
  Files        1569     1569              
  Lines      202517   202529      +12     
==========================================
- Hits       140780   140761      -19     
- Misses      61737    61768      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.