Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vexplain trace #16768

Merged
merged 11 commits into from
Sep 17, 2024

remove trace and reuse vexplain engine primitive

40b1edd
Select commit
Loading
Failed to load commit list.
Merged

Add vexplain trace #16768

remove trace and reuse vexplain engine primitive
40b1edd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2024 in 0s

68.92% (+0.00%) compared to f97ea77

View this Pull Request on Codecov

68.92% (+0.00%) compared to f97ea77

Details

Codecov Report

Attention: Patch coverage is 76.37795% with 30 lines in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (f97ea77) to head (40b1edd).

Files with missing lines Patch % Lines
go/vt/vtgate/engine/vexplain.go 68.33% 19 Missing ⚠️
go/vt/vtgate/vcursor_impl.go 76.00% 6 Missing ⚠️
go/vt/vtgate/engine/plan_description.go 85.18% 4 Missing ⚠️
go/vt/vtgate/planbuilder/vexplain.go 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16768   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files        1566     1566           
  Lines      201886   201983   +97     
=======================================
+ Hits       139149   139222   +73     
- Misses      62737    62761   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov