-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix distributed transactions disruptions test with move table #16765
fix distributed transactions disruptions test with move table #16765
Conversation
…and stress in twopc tests Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16765 +/- ##
==========================================
- Coverage 68.94% 68.93% -0.01%
==========================================
Files 1565 1565
Lines 201764 201764
==========================================
- Hits 139112 139095 -17
- Misses 62652 62669 +17 ☔ View full report in Codecov by Sentry. |
|
||
// WaitForResults waits for the results of the query to be as expected. | ||
func WaitForResults(t *testing.T, vtParams *mysql.ConnParams, query string, resultExpected string, waitTime time.Duration) { | ||
timeout := time.After(waitTime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal preference to always use context.WithTimeout
and then cehck for <- ctx.Done()
. This would also do the right thing for mysqlConnec(ctx, ...)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this PR, I will leave it as-is. As it is concerned with resolving flaky test issues.
Description
Fuzzer test and Stress test were using common state which sometimes leave
twopc_fuzzer_update
table on 2 keyspaces.It causes an ambiguous error on running move tables disruption on the stress test after fuzz test have completed.
The PR split these into two different packages so that they do not interact with each other.
Related Issue(s)
Checklist
Deployment Notes