-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update part of codebase to use new for := range syntax #16738
Conversation
…/mysql/decimal, go/mysql/fastparse Signed-off-by: Christopher Mejia <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Christopher Mejia <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16738 +/- ##
==========================================
+ Coverage 68.93% 68.95% +0.02%
==========================================
Files 1565 1565
Lines 201745 201748 +3
==========================================
+ Hits 139075 139118 +43
+ Misses 62670 62630 -40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice change, thank you @chrism1001!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chrism1001 ! ❤️
Description
This updates a small portion of the codebase to use the new range syntax.
Related Issue(s)
#15193
Checklist
Deployment Notes
N/A