Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Add VTGate VStreamFlag to include journal events in the stream #16737

Merged
merged 3 commits into from
Sep 17, 2024

Remove delay when not stopping on reshard

784a84b
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Add VTGate VStreamFlag to include journal events in the stream #16737

Remove delay when not stopping on reshard
784a84b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

68.93% (-0.01%) compared to a513601, passed because coverage increased by -0.01% when compared to adjusted base (68.93%)

View this Pull Request on Codecov

68.93% (-0.01%) compared to a513601, passed because coverage increased by -0.01% when compared to adjusted base (68.93%)

Details

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (a513601) to head (784a84b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/vstream_manager.go 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16737      +/-   ##
==========================================
- Coverage   68.93%   68.93%   -0.01%     
==========================================
  Files        1565     1565              
  Lines      201745   201753       +8     
==========================================
- Hits       139075   139073       -2     
- Misses      62670    62680      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.