-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the results observer easier to extend, and give it a life cycle #16736
Conversation
Signed-off-by: Andres Taylor <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16736 +/- ##
==========================================
- Coverage 68.93% 68.93% -0.01%
==========================================
Files 1565 1565
Lines 201745 201749 +4
==========================================
- Hits 139075 139073 -2
- Misses 62670 62676 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
We'll solve this another way. |
Description
To make the
resultsObserver
interface really useful, we need to get some additional information.This PR adds the query that started the work on vtgate as a start parameter to the creation of the
resultObserver
, and adds aClose()
method to the interface so that the observer gets notified once no more results are incoming.Related Issue(s)
Following #16638
Checklist