Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authoritative query timeout for vttablet from vtgate #16735

Merged
merged 15 commits into from
Sep 11, 2024

added release notes

a857a5e
Select commit
Loading
Failed to load commit list.
Merged

feat: authoritative query timeout for vttablet from vtgate #16735

added release notes
a857a5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 11, 2024 in 1s

68.93% (-0.02%) compared to e0a5069, passed because coverage increased by +0.00% when compared to adjusted base (68.93%)

View this Pull Request on Codecov

68.93% (-0.02%) compared to e0a5069, passed because coverage increased by +0.00% when compared to adjusted base (68.93%)

Details

Codecov Report

Attention: Patch coverage is 90.35088% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (e0a5069) to head (a857a5e).

Files with missing lines Patch % Lines
go/vt/vtgate/engine/dbddl.go 60.00% 4 Missing ⚠️
go/vt/vtgate/engine/insert_select.go 25.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 90.00% 2 Missing ⚠️
go/vt/sqlparser/comments.go 97.77% 1 Missing ⚠️
go/vt/vtgate/planbuilder/builder.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16735      +/-   ##
==========================================
- Coverage   68.94%   68.93%   -0.02%     
==========================================
  Files        1565     1565              
  Lines      201748   201764      +16     
==========================================
- Hits       139093   139083      -10     
- Misses      62655    62681      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.