schemadiff: reject non-deterministic function in new column's default value #16684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ministic function in column's default value Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
shlomi-noach
added
Type: Enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16684 +/- ##
========================================
Coverage 68.93% 68.94%
========================================
Files 1564 1565 +1
Lines 201371 201553 +182
========================================
+ Hits 138821 138959 +138
- Misses 62550 62594 +44 ☔ View full report in Codecov by Sentry. |
mattlord
approved these changes
Aug 29, 2024
go/vt/schemadiff/errors.go
Outdated
| } | ||
|
|
||
| func (e *NonDeterministicDefaultError) Error() string { | ||
| return fmt.Sprintf("column %s.%s default value uses non-deterministic function: %v", sqlescape.EscapeID(e.Table), sqlescape.EscapeID(e.Column), e.Function) |
There was a problem hiding this comment.
Super nitty, but e.Function is a string so we can use %s instead of %v.
dbussink
reviewed
Aug 29, 2024
go/vt/schemadiff/table.go
Outdated
| foundFunction = node.Name.String() | ||
| return false, nil | ||
| default: | ||
| // recurse into function argument expressions |
There was a problem hiding this comment.
Is this recursion needed? Walk already visits everything doesn't it?
There was a problem hiding this comment.
Confirmed, the recursion is not needed. An earlier iteration led me to believe it was. The existing unit tests already cover two inner function scenarios so this is testes.
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
dbussink
reviewed
Sep 2, 2024
go/vt/schemadiff/table_test.go
Outdated
| from: "create table t1 (id int primary key, a int)", | ||
| to: "create table t2 (id int primary key, a int, v varchar(36) not null default (uuid()))", | ||
| diff: "alter table t1 add column v varchar(36) not null default (uuid())", | ||
| cdiff: "ALTER TABLE `t1` ADD COLUMN `v` varchar(36) NOT NULL DEFAULT (uuid())", |
There was a problem hiding this comment.
If this always errors on MySQL, should it even be a flag on schemadiff or should we also always use error?
There was a problem hiding this comment.
Agreed. Removed the option altogether, the issue title is now misleading and I'll fix it. Confirmed that MySQL rejects this kind of statement even for empty tables (as opposed to another issue we found the other day where the success depends on whether the table is empty or not). This is a bit of inconsistent behavior for MySQL, but at least we're consistent with it...
…'s behavior reliably rejects adding columns with nondeterministic functions, even in the case of empty tables Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
changed the title
NonDeterministicDefaultStrategy, can reject non-deterministic function in column's default value
dbussink
approved these changes
Sep 2, 2024
shlomi-noach
deleted the
schemadiff-reject-non-deterministic-expressions
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new diff hint:NonDeterministicDefaultStrategy, which can take these values:When it's set toNonDeterministicDefaultReject,schemadiffnow errors on table diffs where:SYSDATE()UUID()RAND()This matches MySQL behavior as in:
There is no need to handle
MODIFY COLUMNorCHANGE COLUMNstatements, because those cannot introduce un-computed column data, and only operate on existing columns.Related Issue(s)
Checklist
Deployment Notes