Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change AndExpr to contain arbitrary many predicates #16671

Closed
wants to merge 14 commits into from

remove test not used any more

31b8f71
Select commit
Loading
Failed to load commit list.
Closed

change AndExpr to contain arbitrary many predicates #16671

remove test not used any more
31b8f71
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 29, 2024 in 1s

68.94% (+0.01%) compared to 773a216

View this Pull Request on Codecov

68.94% (+0.01%) compared to 773a216

Details

Codecov Report

Attention: Patch coverage is 90.46243% with 33 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (773a216) to head (31b8f71).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/vexec/query_planner.go 46.15% 7 Missing ⚠️
go/vt/sqlparser/ast_funcs.go 92.00% 6 Missing ⚠️
go/vt/sqlparser/predicate_rewriting.go 96.26% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operators/update.go 70.58% 5 Missing ⚠️
go/vt/vtgate/simplifier/expression_simplifier.go 0.00% 4 Missing ⚠️
go/vt/vtgate/planbuilder/operators/ast_to_op.go 95.12% 2 Missing ⚠️
go/vt/sqlparser/random_expr.go 83.33% 1 Missing ⚠️
go/vt/vtctl/workflow/materializer.go 50.00% 1 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 1 Missing ⚠️
go/vt/vtctl/workflow/vexec/query_plan.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16671      +/-   ##
==========================================
+ Coverage   68.92%   68.94%   +0.01%     
==========================================
  Files        1562     1564       +2     
  Lines      200941   201360     +419     
==========================================
+ Hits       138497   138825     +328     
- Misses      62444    62535      +91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov