Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions in the concatenate engine streaming #16640

Merged
merged 4 commits into from
Aug 26, 2024

feat: address review comments

bcec73c
Select commit
Loading
Failed to load commit list.
Merged

Fix race conditions in the concatenate engine streaming #16640

feat: address review comments
bcec73c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2024 in 1s

68.98% (-0.01%) compared to 538dd4c, passed because coverage increased by -0.01% when compared to adjusted base (68.98%)

View this Pull Request on Codecov

68.98% (-0.01%) compared to 538dd4c, passed because coverage increased by -0.01% when compared to adjusted base (68.98%)

Details

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (538dd4c) to head (bcec73c).
Report is 6 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/engine/concatenate.go 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16640      +/-   ##
==========================================
- Coverage   68.98%   68.98%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      200690   200740      +50     
==========================================
+ Hits       138449   138476      +27     
- Misses      62241    62264      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.