Performance improvements - Planner #16631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
systay
added
Component: Query Serving
Type: Performance
and removed
NeedsDescriptionUpdate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16631 +/- ##
==========================================
- Coverage 68.99% 68.93% -0.06%
==========================================
Files 1562 1562
Lines 200754 200758 +4
==========================================
- Hits 138508 138393 -115
- Misses 62246 62365 +119 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
GuptaManan100
approved these changes
Aug 26, 2024
Comment on lines
-64
to
-66
| if len(operators) < 2 { | ||
| panic("incorrect count of inputs for FkCascade") | ||
| } |
There was a problem hiding this comment.
Maybe we should put all these checks behind a debug mode? 🤔 Would that help us in debugging when a user reports a query is not working as intended? Also, won't removing these make some plans pass that would otherwise panic that could return wrong rows?
There was a problem hiding this comment.
I changed the code so that we now only use SetInputs() on the output of GetInputs(). Is that enough you think?
Signed-off-by: Andres Taylor <[email protected]>
frouioui
approved these changes
Aug 26, 2024
|
Good Riddance to calling Clone in rewriters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on improving the performance of the Vitess planner by analyzing profiler output and implementing optimizations that reduce execution time, memory usage, and allocations. The changes are aimed at making the planner faster and more efficient, especially for complex queries.
Benchmark Results
The benchmarks were run on an Apple M1 Ultra and demonstrate significant improvements across various metrics:
Execution Time (sec/op):
Memory Usage (B/op):
Allocations (allocs/op):
Related Issue(s)
#16789
Checklist
Deployment Notes