-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed the pinned-dependencies #16612
Conversation
Signed-off-by: harshitasao <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <[email protected]>
Looks good! We create the workflow files from templates, so I added a commit to your branch updating the templates as well. After changing the templates, you can check that it looks good by using:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16612 +/- ##
==========================================
+ Coverage 68.83% 68.88% +0.04%
==========================================
Files 1558 1562 +4
Lines 200042 200673 +631
==========================================
+ Hits 137693 138227 +534
- Misses 62349 62446 +97 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you for taking that on.
FYI @vitessio/maintainers, we should continue writing our workflows that way.
Found the GitHub documentation about this: https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions
Description
fixed the pinned-dependencies reported by the scorecard.
Related Issue(s)
Part of #16607
Checklist
Deployment Notes