v20 backport: Online DDL: avoid SQL's CONVERT(...), convert programmatically if needed

[shlomi-noach]

Manual backport of #16597 to release-20.0

(bot is not working)

Description

Fixes #16023

We have a clear picture and a fix to #16023. The original reason why we needed convert() in the first place is that vreplication and vstreamer both issue a SET NAMES binary. We will want to change that in the future, but this PR in the meantime confirms to the binary connection charset.

So we used convert() to turn textual values into utf8mb4. On the other side, vplayer is reading events from the binary log. It used programmatic conversion (charset.Convert()) of the data to utf8mb4 to align with vcopier.

What we are doing now:

• We do not use convert(), solving the sorting issue described in Bug Report: OnlineDDL PK conversion results in table scans #16023 (comment)
• For vcopier read data, We do introduce programmatic conversion of non-utf columns into their designated charsets.
• For vplayer, we do not convert at all if both source and target have same charset
• For vplayer, we do apply programmatic conversion of non-utf columns into their designated charsets, in a similar logic as for vcopier.
• If there's a charset.Convert() error, we translate it into ERROR 1366 ("Incorrect string value ..."), which is a terminal error in vreplication, and so the migration bails out as soon as that happens. This can happen if e.g. we're converting a UTF column into ASCII and the UTF column contains a smiley emoji.

Because we do not convert the original charset to utf8mb4, we get to programmatically convert it to the specific target column. Previously (and this is perhaps the last piece of magic I have not digged into yet, and again likely to be caused by the binary charset) we did not need to convert into the target charset.

All the tests remain the same, and we introduce a couple new ones.

Related Issue(s)

• Bug Report: OnlineDDL PK conversion results in table scans #16023
• supersedes Online DDL: do not CONVERT column charset when migration does not modify column's charset or collation #16594

Backport

I wish to backport this to all supported versions, seeing that this is a bugfix: without this fix some migrations will slow down to a near halt.

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 39.47368% with 23 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (3f926b6) to head (f6f64b7).
Report is 1 commits behind head on release-20.0.

Files	Patch %	Lines
...blet/tabletmanager/vreplication/replicator_plan.go	46.87%	17 Missing ⚠️
go/vt/vttablet/onlineddl/vrepl.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release-20.0   #16602   +/-   ##
=============================================
  Coverage         68.67%   68.67%           
=============================================
  Files              1541     1541           
  Lines            197870   197890   +20     
=============================================
+ Hits             135892   135910   +18     
- Misses            61978    61980    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.