Pr 13582 #16586
Closed
Pr 13582 #16586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
* Release notes for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <[email protected]> * Release commit for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
* feat: call the logic for waiting for shard locks on synchronous on-term hooks and add tests for it Signed-off-by: Manan Gupta <[email protected]> * feat: fix comment for acceptSighupSignal function Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
… creation (#11415) (#11447) * Testing.... Signed-off-by: Matt Lord <[email protected]> * Setup reverse routing rules at the start of the first partial movetables. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched Signed-off-by: Rohit Nayak <[email protected]> * Update display representation of state for partially moved keyspaces Signed-off-by: Rohit Nayak <[email protected]> * Test improvements Signed-off-by: Matt Lord <[email protected]> * Cleanup shard routing rules on cancel/complete Signed-off-by: Matt Lord <[email protected]> * Cleanup intermediate changes Signed-off-by: Matt Lord <[email protected]> * Fix DryRun TrafficSwitcher and its tests Signed-off-by: Matt Lord <[email protected]> * Support concurrent partial movetables for N keyspaces And other minor changes after self review Signed-off-by: Matt Lord <[email protected]> * Avoid unnecessary save + rebuild steps Signed-off-by: Matt Lord <[email protected]> * Add secondary ordering for shard routing rules on to_keyspace Signed-off-by: Matt Lord <[email protected]> * Minor changes after self review Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
…e correct binary. (#11450) Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Rohit Nayak <[email protected]>
* Use JSON for plan tests Signed-off-by: Florent Poinsard <[email protected]> * move vschemas into single directory Signed-off-by: Andres Taylor <[email protected]> * indentation Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: FlorentP <[email protected]>
Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
This is to pick up the fix for golang/go#56152. Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…nShard`, `GetFullStatus` (#11438) (#11452) * Add validate Signed-off-by: notfelineit <[email protected]> * Add validate to cluster page Signed-off-by: notfelineit <[email protected]> * Run lint prettier fix Signed-off-by: notfelineit <[email protected]> * Add UI for validate shard Signed-off-by: notfelineit <[email protected]> * Add validateShard Signed-off-by: notfelineit <[email protected]> * Run make web proto Signed-off-by: notfelineit <[email protected]> * Refactor validation results and implement validateShard Signed-off-by: notfelineit <[email protected]> * add http shards Signed-off-by: notfelineit <[email protected]> * Add GetFullStatus Signed-off-by: notfelineit <[email protected]> * Add keys and comment Signed-off-by: notfelineit <[email protected]> * Run lint prettier fix Signed-off-by: notfelineit <[email protected]> * Add ValidateVersionShard to vtctldclient Signed-off-by: notfelineit <[email protected]> * Add ValidateVersionShard Signed-off-by: notfelineit <[email protected]> * Update test for vtctldclient Signed-off-by: notfelineit <[email protected]> * Add test for ValidateVersionShard Signed-off-by: notfelineit <[email protected]> * run lint prettier fix again Signed-off-by: notfelineit <[email protected]> * Modify during 1:1 with gomez Signed-off-by: notfelineit <[email protected]> * Run lint prettier fix Signed-off-by: notfelineit <[email protected]> * Address PR review comments Signed-off-by: notfelineit <[email protected]> * Update indentation Signed-off-by: notfelineit <[email protected]> Signed-off-by: notfelineit <[email protected]> Co-authored-by: notfelineit <[email protected]>
* Fix check_make_sizegen Signed-off-by: Florent Poinsard <[email protected]> * Apply review suggestion Signed-off-by: Florent Poinsard <[email protected]> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <[email protected]> * Remove test code Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
* feat: add replacer and code to always print semi-sync fields and decode the io and sql state from integers to strings Signed-off-by: Manan Gupta <[email protected]> * refactor: prettify the changed file Signed-off-by: Manan Gupta <[email protected]> * feat: fix replication state strings and simplify code Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
…action Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
* Plan order by Count() Signed-off-by: Florent Poinsard <[email protected]> * Clean up the new aggregation E2E test Signed-off-by: Florent Poinsard <[email protected]> * Push more order by needs to the select list Signed-off-by: Florent Poinsard <[email protected]> * Remove unrequired code in TestOrderByCount Signed-off-by: Florent Poinsard <[email protected]> * remove unwanted directory Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
…k overflow (#11499) Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>
* test: added failing e2e test Signed-off-by: Harshit Gangal <[email protected]> * log txID and reserveID in stream execute Signed-off-by: Harshit Gangal <[email protected]> * fix: maintain list of qd per key on the map and check for current connection id while removing Signed-off-by: Harshit Gangal <[email protected]> * added additional comments Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
[release-15.0] fix: reserve connection to follow query timeout when outside of transaction (#11490)
* feat: added test for vtorc not being able to handle mutliple failures and fix it Signed-off-by: Manan Gupta <[email protected]> * test: fix code to delete rdonly tablet from the correct list Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
* Adding deprecate message to backup hooks Signed-off-by: Rameez Sajwani <[email protected]> * adding markdeprecated Signed-off-by: Rameez Sajwani <[email protected]> * fixing deprecation message Signed-off-by: Rameez Sajwani <[email protected]> * fixing messaging Signed-off-by: Rameez Sajwani <[email protected]> * fix flag name Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
* removing unncessary flags across binaries Signed-off-by: Rameez Sajwani <[email protected]> * code review feedback Signed-off-by: Rameez Sajwani <[email protected]> * fixing blank space Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
[15.0] Fix query list override issue on mysql restart (#11309)
* remove excessive logging Signed-off-by: Rameez Sajwani <[email protected]> * code feeback Signed-off-by: Rameez Sajwani <[email protected]> * fixing typo Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
* Move CI to mysql80 Signed-off-by: Rameez Sajwani <[email protected]> * fix typo Signed-off-by: Rameez Sajwani <[email protected]> * fixing typo Signed-off-by: Rameez Sajwani <[email protected]> * moving to apt-config 8.2 Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
I accidentally stumbled over the behavior outlined in `flag.PrintDefaults` [1], which `pflag` replicates, specifically: > The listed type, here int, can be changed by placing a back-quoted > name in the flag's usage string; the first such item in the message is > taken to be a parameter name to show in the message and the back quotes > are stripped from the message when displayed. [1]: https://pkg.go.dev/flag#PrintDefaults. Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>
…th transaction (#11527) * fix: stream exec once in case of transactional connection Signed-off-by: Harshit Gangal <[email protected]> * test: added e2e test Signed-off-by: Harshit Gangal <[email protected]> * generate ci worflow Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>
* add vtgate flag that explicitly allows vstream copy (#125) * fix fs.BoolVar Signed-off-by: Tim Vaillancourt <[email protected]> * VSCopy: Resume the copy phase consistently from given GTID and lastpk (#11103) * VSCopy: Demonstrate to fail a test case on which the vstream API is supposed to resume the copy phase consistently Signed-off-by: yoheimuta <[email protected]> * VSCopy: Resume the copy phase consistently from given GTID and lastpk Signed-off-by: yoheimuta <[email protected]> * Build out the unit test some more Signed-off-by: Matt Lord <[email protected]> * Update tests for new behavior Signed-off-by: Matt Lord <[email protected]> * Improve comments Signed-off-by: Matt Lord <[email protected]> * Limit uvstreamer changes and update test Signed-off-by: Matt Lord <[email protected]> * Revert uvstreamer test changes Signed-off-by: Matt Lord <[email protected]> * Revert all uvstream changes Signed-off-by: Matt Lord <[email protected]> * VCopy: Revert the last three commits Signed-off-by: yoheimuta <[email protected]> * VCopy: Add a new vstream type that allows picking up where we left off Signed-off-by: yoheimuta <[email protected]> * VCopy: Revert the unit test change Signed-off-by: yoheimuta <[email protected]> * VCopy: Fix the end-to-end CI test Signed-off-by: yoheimuta <[email protected]> * Update logic for setting up uvstreamer based on input vgtid/tablepks. Add more catchup events to test Signed-off-by: Rohit Nayak <[email protected]> * Refactor logic to decide if event is to be sent. Enhance unit and e2e tests. Signed-off-by: Rohit Nayak <[email protected]> * Don't send events for tables which we can identify as ones we haven't started copy for Signed-off-by: Rohit Nayak <[email protected]> * Minor changes after self-review Signed-off-by: Rohit Nayak <[email protected]> * Add vstream copy resume to release notes Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> Signed-off-by: yoheimuta <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> * VSCopy: Send COPY_COMPLETED events when the copy operation is done (#11740) * VSCopy: Demonstrate to fail a test case on which the vstream API sends new events showing copy completed Signed-off-by: yoheimuta <[email protected]> * VSCopy: Send new events when the copy operation is done Signed-off-by: yoheimuta <[email protected]> * VSCopy: Fix typo Signed-off-by: yoheimuta <[email protected]> * Initialize new map for the 'vstream * from' vtgate sql interface. Make vtadmin web protos Signed-off-by: Rohit Nayak <[email protected]> * VSCopy: Make TestVStreamCopyBasic fail fast to avoid the end2end timeout out Signed-off-by: yoheimuta <[email protected]> * VSCopy: stop sharing the 't1' table among multiple test cases running concurrently Signed-off-by: yoheimuta <[email protected]> * VSCopy: refactor the function signature to be clearer Signed-off-by: yoheimuta <[email protected]> * VSCopy: refactor the VEvents sorter to be simpler Signed-off-by: yoheimuta <[email protected]> * VSCopy: refactor to stop the sorter from including a fully copied event Signed-off-by: yoheimuta <[email protected]> Signed-off-by: yoheimuta <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> * VSCopy: Enable to copy from all shards in either a specified keyspace or all keyspaces (#11909) * VSCopy: Demonstrate to fail a test case on which the vstream API request doesn't include keyspace and shard Signed-off-by: yoheimuta <[email protected]> * VSCopy: Copy from all shards in all keyspaces by specifying only an empty gtid Signed-off-by: yoheimuta <[email protected]> * tests: Make TestRowCount stable regardless of the number of keyspaces Signed-off-by: yoheimuta <[email protected]> * tests: Cleanup TestCreateAndDropDatabase correctly to stop TestVStreamCopyWithoutKeyspaceShard from failing when running tests together Signed-off-by: yoheimuta <[email protected]> * tests: Tweak to fix a comment Signed-off-by: yoheimuta <[email protected]> * VSCopy: fix the unit tests when the input vgtid with an empty gtid lacks either keyspace or shard Signed-off-by: yoheimuta <[email protected]> * VSCopy: Keyspace wildcard selection lines up with the table wildcard selection Signed-off-by: yoheimuta <[email protected]> * VSCopy: Tests the VCopy with multiple keyspaces and resharding Signed-off-by: yoheimuta <[email protected]> * VSCopy: Make TestVStreamCopyMultiKeyspaceReshard clearer to check if the streaming two keyspaces works even after reshard Signed-off-by: yoheimuta <[email protected]> * VSCopy: Return an invalid argument error if shards are unspecified and gtid is neither 'current' nor empty Signed-off-by: yoheimuta <[email protected]> * VSCopy: Add a test description about its purpose and target Signed-off-by: yoheimuta <[email protected]> * VSCopy: Remove duplicate literals in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Retain defaultReplicas variable in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Explain why we are setting Match to 'customer.*' in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Remove an unused VStreamFlag for the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Use sentence capitalization in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Verify that we didn't lose any events or get duplicates of the keyspace being reshareded in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Return a value instead of a pointer because there is no need to modify the value Signed-off-by: yoheimuta <[email protected]> * VSCopy: Add a comment describing what TestVStreamCopyFromAllKeyspacesAndAllShards is doing and why Signed-off-by: yoheimuta <[email protected]> * VSCopy: Add a comment describing why we expect these specific numbers of events from VStream API Signed-off-by: yoheimuta <[email protected]> * VSCopy: Tweak the test case name Signed-off-by: yoheimuta <[email protected]> * VSCopy: Make a utility function to sort COPY_COMPLETED events in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Replace the matcher with a simpler one in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Move the print debug call to the FailNow section in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Use require.NoError in new tests Signed-off-by: yoheimuta <[email protected]> * VSCopy: Use require instead of t.Fatalf in the test Signed-off-by: yoheimuta <[email protected]> * VSCopy: Apply the reviewer's suggestion to make the error message easier to read Signed-off-by: yoheimuta <[email protected]> * VSCopy: Add a comment noting what we're actually testing Signed-off-by: yoheimuta <[email protected]> * VSCopy: Correct the test comment and elaborate the special-case Signed-off-by: yoheimuta <[email protected]> * VSCopy: Tweak an error message and a comment Signed-off-by: yoheimuta <[email protected]> * VSCopy: Adjust to a change in the signature of a test function that was introduced in the main repository Signed-off-by: yoheimuta <[email protected]> --------- Signed-off-by: yoheimuta <[email protected]> * attempt unit test fix Signed-off-by: Tim Vaillancourt <[email protected]> * update test error expected Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: yoheimuta <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: pbibra <[email protected]> Co-authored-by: yohei yoshimuta <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
* `slack-15.0`: basic go.mod updates Signed-off-by: Tim Vaillancourt <[email protected]> * fix signature in `go/vt/mysqlctl/azblobbackupstorage/azblob.go` Signed-off-by: Tim Vaillancourt <[email protected]> * update expected error for new mysql driver Signed-off-by: Tim Vaillancourt <[email protected]> * more go.mod updates Signed-off-by: Tim Vaillancourt <[email protected]> * steal statsd fix from vitessio/vitess#11741 Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> * update flag e2e tests Signed-off-by: Tim Vaillancourt <[email protected]> * update flag e2e tests Signed-off-by: Tim Vaillancourt <[email protected]> * update flag e2e tests Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
* [release-17.0] VReplication: Take replication lag into account in VStreamManager healthcheck result processing (#15761) (#15772) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]> * fix signature Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]>
* Add sql text counts stats to `vtcombo`,`vtgate`+`vttablet` Signed-off-by: Tim Vaillancourt <[email protected]> * initialize sqlTextCounts where missed Signed-off-by: Harshit Gangal <[email protected]> * missing fix Signed-off-by: Tim Vaillancourt <[email protected]> * fix accidental line delete Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
* `vtgate`: support filtering tablets by tablet-tags (#15911) Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> * Add support for sampling rate in `streamlog` (#15919) Signed-off-by: Tim Vaillancourt <[email protected]> * Fix merge conflict resolution Signed-off-by: Tim Vaillancourt <[email protected]> * update rand import Signed-off-by: Tim Vaillancourt <[email protected]> * Add sql text counts stats to `vtcombo`,`vtgate`+`vttablet` (#15897) Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]> * missing rename Signed-off-by: Tim Vaillancourt <[email protected]> * missing rename again Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> Co-authored-by: Harshit Gangal <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
…torc (#15991) (#405) * Add timeout to all the contexts used for RPC calls in vtorc (#15991) Signed-off-by: Manan Gupta <[email protected]> * add context that didn't merge well Signed-off-by: Tim Vaillancourt <[email protected]> * revert unneeded tm_client.go change Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
implement flow based tablet load balancer Signed-off-by: Michael Demmer <[email protected]> Signed-off-by: Venkatraju V <[email protected]> Co-authored-by: Michael Demmer <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
…on` (#442) * `slack-15.0`: reset semi-sync in `setReplicationSourceRepairReplication` Signed-off-by: Tim Vaillancourt <[email protected]> * reorder shard lock Signed-off-by: Tim Vaillancourt <[email protected]> * try 100% percona-xtrabackup-80 Signed-off-by: Tim Vaillancourt <[email protected]> * Revert "try 100% percona-xtrabackup-80" This reverts commit e67be76. * percona-xtrabackup-24 problem fix attempt 2 Signed-off-by: Tim Vaillancourt <[email protected]> * remove currentPrimary Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit to fix CI --------- Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
twthorn
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
notfelineit,
frouioui,
rohit-nayak-ps,
GuptaManan100,
systay,
shlomi-noach,
timvaillancourt,
arthurschreiber and
derekperkins
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes