-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throttler (v22): towards formal gRPC calls in endtoend tests, removing HTTP API calls #16530
base: main
Are you sure you want to change the base?
Conversation
… API calls Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16530 +/- ##
==========================================
- Coverage 67.49% 67.48% -0.01%
==========================================
Files 1577 1577
Lines 253416 253374 -42
==========================================
- Hits 171045 170994 -51
- Misses 82371 82380 +9 ☔ View full report in Codecov by Sentry. |
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…uch output Signed-off-by: Shlomi Noach <[email protected]>
…r response Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
|
Signed-off-by: Shlomi Noach <[email protected]>
…tler/check' which is used by gh-ost and pt-osc Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
79d2ac0
to
4129d2e
Compare
4129d2e
to
79d2ac0
Compare
Signed-off-by: Shlomi Noach <[email protected]>
Description
For
v22
This PR removes any references to
/throttler/*
API calls, and uses gRPC instead.This is to be done in
v22
(right afterv21
is released) because someendtoend
tests and functionality is used in upgrade/downgrade testing and needs to keep supporting HTTP endpoints.Related Issue(s)
#15624
Checklist
Deployment Notes