-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shcemadiff
: support INSTANT
DDL for changing column visibility
#16503
shcemadiff
: support INSTANT
DDL for changing column visibility
#16503
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Shlomi Noach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16503 +/- ##
==========================================
+ Coverage 68.63% 68.64% +0.01%
==========================================
Files 1551 1552 +1
Lines 199515 199559 +44
==========================================
+ Hits 136938 136990 +52
+ Misses 62577 62569 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
While not documented in https://dev.mysql.com/doc/refman/8.0/en/innodb-online-ddl-operations.html, changing column visibility is
INSTANT
-able, and this PR adds this analysis inschemadiff
.While at it,
INSTANT
DDL analysis now also supportsCHANGE COLUMN
statements where the column name is unchanged, as well asALTER COLUMN
statements. It's noteworthy thatschemadiff
itself only generatesMODIFY COLUMN
statements and never either of these two, and this support comes just for completeness.Related Issue(s)
INSTANT
-capable changes #14877Checklist
Deployment Notes