Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cross cell promotion in PRS #16461

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Allow cross cell promotion in PRS #16461

merged 5 commits into from
Jul 25, 2024

Conversation

GuptaManan100
Copy link
Member

Description

As described in #16460, there is a need to allow cross cell promotions in PRS. This PR adds this functionality and adds the required tests to ensure it works as intended.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management labels Jul 23, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 23, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 23, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 23, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.64%. Comparing base (f481a77) to head (8e01681).

Files Patch % Lines
go/vt/vtctl/reparent.go 0.00% 6 Missing ⚠️
go/cmd/vtctldclient/command/reparents.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16461      +/-   ##
==========================================
- Coverage   68.65%   68.64%   -0.01%     
==========================================
  Files        1551     1551              
  Lines      199468   199473       +5     
==========================================
- Hits       136935   136920      -15     
- Misses      62533    62553      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shlomi-noach
shlomi-noach approved these changes Jul 24, 2024
View reviewed changes
go/vt/vtctl/reparentutil/util.go Outdated
@@ -102,7 +103,7 @@ func ElectNewPrimary(
reasonsToInvalidate.WriteString(fmt.Sprintf("\n%v does not match the new primary alias provided", topoproto.TabletAliasString(tablet.Alias)))
continue
}
case primaryCell != "" && tablet.Alias.Cell != primaryCell:
case !allowCrossCellPromotion && primaryCell != "" && tablet.Alias.Cell != primaryCell:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual logic change in this PR. LGTM

@GuptaManan100 GuptaManan100 merged commit 88d7033 into vitessio:main Jul 25, 2024
132 checks passed
@GuptaManan100 GuptaManan100 deleted the allow-cross-cell branch July 25, 2024 06:40
@GuptaManan100 GuptaManan100 mentioned this pull request Jul 26, 2024
Closed
@arthurschreiber arthurschreiber mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi deepthi approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow cross cell promotion in PRS
4 participants
@GuptaManan100 @deepthi @shlomi-noach @harshit-gangal