-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemadiff
: optimize permutation evaluation
#16435
schemadiff
: optimize permutation evaluation
#16435
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16435 +/- ##
==========================================
- Coverage 68.68% 68.68% -0.01%
==========================================
Files 1548 1548
Lines 199096 199124 +28
==========================================
+ Hits 136751 136766 +15
- Misses 62345 62358 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice optimization!
Description
Implements the optimization proposed in #16434
This PR modifies the algorithm by optimizing it. I keeps all existing tests unchanged so as to prove that the modification does not change actual results.
Related Issue(s)
#16434
Checklist
Deployment Notes