Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dual queries with LIMIT on the vtgate #16400

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 16, 2024

Description

Dual queries can most of the time be handled on the vtgate side, without having to send anything down to MySQL.

This PR extends this functionality to include dual queries with LIMIT in them.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Jul 16, 2024
Copy link
Contributor

vitess-bot bot commented Jul 16, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 16, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 16, 2024
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 16, 2024
@systay systay changed the title dual queries with LIMIT can still be handled on the vtgate Handle dual queries with LIMIT on the vtgate Jul 16, 2024
Signed-off-by: Andres Taylor <[email protected]>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.68%. Comparing base (66bf89b) to head (50db00a).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/planbuilder/select.go 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16400      +/-   ##
==========================================
+ Coverage   68.66%   68.68%   +0.02%     
==========================================
  Files        1548     1548              
  Lines      199084   199098      +14     
==========================================
+ Hits       136699   136751      +52     
+ Misses      62385    62347      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay merged commit 96974ef into vitessio:main Jul 18, 2024
128 checks passed
@systay systay deleted the dual-on-vtgate branch July 18, 2024 05:28
frouioui pushed a commit to frouioui/vitess that referenced this pull request Jul 19, 2024
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants