VTAdmin: Show throttled status in workflows

[rohit-nayak-ps]

Description

When a VReplication workflow is throttled, the app that caused the throttling and the time of the last throttle are recorded in the _vt.vreplication table. Currently those attributes are only shown in the json output tab of the workflow screen and are not easy to find.

The throttler app and time are not reset once throttling has ended. So we only show a stream as throttled if it is within (currently) a minute. The throttler is updating this row on each check (every 250ms - 1s).

This PR changes the status color for a throttled running workflow to black and adds the throttler details (app name and time since throttled) to the summary workflow tooltip and to the streams details section.

It also adds a new internal link in the header to scroll down to the Streams section for convenience and visibility.

Workflow summary page

Workflow Streams Section

Related Issue(s)

#11690

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (bb76046) to head (e58999b).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16308      +/-   ##
==========================================
+ Coverage   68.71%   68.72%   +0.01%     
==========================================
  Files        1544     1547       +3     
  Lines      198011   198270     +259     
==========================================
+ Hits       136064   136269     +205     
- Misses      61947    62001      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rohit-nayak-ps]

Current test failures are due to the issue with installing xtrabackup ...

[mattlord]

I think there's still a misunderstanding baked in here about what the throttler info means. If a workflow was throttled 6 hours ago, that would be reflected in the record. That does NOT mean, however, that we've been throttled for 6 hours. In fact it means the opposite, we haven't been throttled in 6 hours.

[mattlord]

Aren't we showing it if it's been throttled in the last minute? I don't see how we can answer "for more than 5 seconds" or how we're attempting to do that here.

[mattlord]

throttledAt would be more accurate here

[mattlord]

Recently Throttled would be correct.

[mattlord]

Another place where we're treating the last throttled time as if we've been throttled since then when it only indicates when we were last throttled. You can tell if you're constantly being throttled by watching this value over time.

[notfelineit]

thanks Rohit!