-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No usage of math/rand #16264
No usage of math/rand #16264
Conversation
This fixes some usages of math/rand and replaces it with math/rand/v2. It also adds a linter check to ensure we don't add new cases anymore. Signed-off-by: Dirkjan Bussink <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16264 +/- ##
=======================================
Coverage 68.60% 68.60%
=======================================
Files 1544 1544
Lines 198016 198016
=======================================
+ Hits 135849 135852 +3
+ Misses 62167 62164 -3 ☔ View full report in Codecov by Sentry. |
@@ -3,6 +3,13 @@ run: | |||
timeout: 10m | |||
|
|||
linters-settings: | |||
depguard: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This fixes some usages of math/rand and replaces it with math/rand/v2. It also adds a linter check to ensure we don't add new cases anymore.
Related Issue(s)
Followup to #15513 but also enforces no regressions here.
Checklist