Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Improve workflow cancel/delete #15977

Merged
merged 37 commits into from
Jun 12, 2024

Correct comment

904ba09
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Improve workflow cancel/delete #15977

Correct comment
904ba09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2024 in 1s

68.51% (+0.31%) compared to 87ecae7

View this Pull Request on Codecov

68.51% (+0.31%) compared to 87ecae7

Details

Codecov Report

Attention: Patch coverage is 45.05929% with 139 lines in your changes missing coverage. Please review.

Project coverage is 68.51%. Comparing base (87ecae7) to head (904ba09).
Report is 12 commits behind head on main.

Files Patch % Lines
go/vt/vtctl/workflow/switcher_dry_run.go 22.42% 83 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 57.35% 29 Missing ⚠️
go/vt/vtctl/workflow/server.go 61.42% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15977      +/-   ##
==========================================
+ Coverage   68.19%   68.51%   +0.31%     
==========================================
  Files        1541     1543       +2     
  Lines      197369   197693     +324     
==========================================
+ Hits       134605   135445     +840     
+ Misses      62764    62248     -516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.