Remove highcharts dependency pt. 1

[notfelineit]

Description

This PR begins replacing highcharts with d3. We need to remove highcharts dependency because it does not meet licensing requirements for Vitess.

This PR removes the highcharts charts, and implements a bare minimum graph.

New graph:

Old graph:

Please see the "issue" section for what features are missing in this PR, compared to the old highcharts graphs.

Related Issue(s)

This PR addresses the following checkboxes of #16032 :

Remove highcharts

• Remove all highcharts components
• Uninstall highcharts

Feature parity

• Shows all timeseries
• Has customizable y axis units
• Has on-hover legend
• Can click legend and filter timeseries

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

We won't reach parity with the highcharts in this PR. There will be subsequent PRs that implement the other features - the priority of this PR is to remove highcharts.

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[notfelineit]

I'll update the changelog in this PR as well, as well as update the old tests that reference old charts code.

[mattlord]

I'm JS illiterate, but there are some linter warnings that we should address. It also seemed like we might have accidentally added an unnecessary/unwanted line in the package file.

[mattlord]

I think this is fine, but we don't typically NEED to change the year when updating an existing file.

[deepthi]

+1

[notfelineit]

Ah, that's good to know. I thought someone had told me that we needed to in the past (it may have just been for net-new files). I won't update them going forwards.

[notfelineit]

@mattlord I always intended to fix the linter issues 😄 my ask for review is for the structure and usage of the code.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.25%. Comparing base (bec711b) to head (8427b0e).
Report is 2 commits behind head on main.

❗ Current head 8427b0e differs from pull request most recent head 6c71610

Please upload reports for the commit 6c71610 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15970      +/-   ##
==========================================
+ Coverage   68.23%   68.25%   +0.02%     
==========================================
  Files        1541     1541              
  Lines      197187   197168      -19     
==========================================
+ Hits       134546   134576      +30     
+ Misses      62641    62592      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iheanyi]

From a pass at it, it LGTM

[no-itsbackpack]

react changes look good to merge 🚀

[dgraham]

⚡️

[dgraham]

Maybe add @types/d3 too?

[notfelineit]

✨ absolutely, TY

[mattlord]

Thanks! ❤️