feat: add support for WITH ROLLUP #15930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
systay
added
Type: Enhancement
systay
requested review from
rohit-nayak-ps,
mattlord,
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
systay
removed
NeedsDescriptionUpdate
frouioui
approved these changes
May 13, 2024
There was a problem hiding this comment.
Just one nit, the rest looks good to me but let's see what @GuptaManan100 says about the shit/reduce introduced. Approving this for now 🚀
| @@ -42,11 +42,11 @@ func isMergeable(ctx *plancontext.PlanningContext, query sqlparser.SelectStateme | |||
|
|
|||
| switch node := query.(type) { | |||
| case *sqlparser.Select: | |||
| if len(node.GroupBy) > 0 { | |||
| if node.GroupBy != nil && len(node.GroupBy.Exprs) > 0 { | |||
There was a problem hiding this comment.
Since we are setting group by to nil everytime we empty it, it should be fine to just check for node.GroupBy != nil.
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
GuptaManan100
approved these changes
May 14, 2024
Signed-off-by: Andres Taylor <[email protected]>
| @@ -375,7 +376,7 @@ func markBindVariable(yylex yyLexer, bvar string) { | |||
| %token <str> ST_Area ST_Centroid ST_ExteriorRing ST_InteriorRingN ST_NumInteriorRings ST_NumGeometries ST_GeometryN ST_LongFromGeoHash ST_PointFromGeoHash ST_LatFromGeoHash ST_GeoHash ST_AsGeoJSON ST_GeomFromGeoJSON | |||
|
|
|||
| // Match | |||
| %token <str> MATCH AGAINST BOOLEAN LANGUAGE WITH QUERY EXPANSION WITHOUT VALIDATION | |||
| %token <str> MATCH AGAINST BOOLEAN LANGUAGE WITH QUERY EXPANSION WITHOUT VALIDATION ROLLUP | |||
There was a problem hiding this comment.
ROLLUP needs to be added to the list of non-reserved keywords list in the end of the file.
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
dbussink
approved these changes
May 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15930 +/- ##
==========================================
- Coverage 68.45% 68.45% -0.01%
==========================================
Files 1559 1559
Lines 196825 196872 +47
==========================================
+ Hits 134736 134764 +28
- Misses 62089 62108 +19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds parser support for
GROUP BY... WITH ROLLUP. Before this, Vitess did not supportWITH ROLLUP.This PR only adds parser support - queries using
WITH ROLLUPon unsharded keyspaces will be able to use these queries. If the query needs to be split across multiple shards,vtgatewill fail with an unsupported error.Related Issue(s)
Fixes #7476
Checklist