Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/cmd: Audit and fix context.Background() usage #15928

Merged
merged 2 commits into from
May 15, 2024

Add comments

cf32fe9
Select commit
Loading
Failed to load commit list.
Merged

go/cmd: Audit and fix context.Background() usage #15928

Add comments
cf32fe9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 14, 2024 in 0s

68.46% (+0.01%) compared to 473c49a

View this Pull Request on Codecov

68.46% (+0.01%) compared to 473c49a

Details

Codecov Report

Attention: Patch coverage is 1.56250% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 68.46%. Comparing base (473c49a) to head (cf32fe9).
Report is 1 commits behind head on main.

Files Patch % Lines
go/cmd/vtcombo/cli/main.go 0.00% 22 Missing ⚠️
go/cmd/vtcombo/cli/vschema_watcher.go 0.00% 7 Missing ⚠️
go/cmd/vtgate/cli/cli.go 0.00% 6 Missing ⚠️
go/cmd/vttablet/cli/cli.go 0.00% 6 Missing ⚠️
go/cmd/vtbackup/cli/vtbackup.go 0.00% 5 Missing ⚠️
go/cmd/vtctldclient/command/legacy_shim.go 0.00% 3 Missing ⚠️
go/cmd/mysqlctld/cli/mysqlctld.go 0.00% 2 Missing ⚠️
go/cmd/vtexplain/cli/vtexplain.go 0.00% 2 Missing ⚠️
go/cmd/mysqlctl/command/init.go 0.00% 1 Missing ⚠️
go/cmd/mysqlctl/command/shutdown.go 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15928      +/-   ##
==========================================
+ Coverage   68.45%   68.46%   +0.01%     
==========================================
  Files        1559     1559              
  Lines      196872   196871       -1     
==========================================
+ Hits       134769   134789      +20     
+ Misses      62103    62082      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov