-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add missing/required tests for sqltypes
and mathstats
#15920
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15920 +/- ##
==========================================
+ Coverage 68.43% 68.47% +0.03%
==========================================
Files 1559 1559
Lines 196753 196825 +72
==========================================
+ Hits 134657 134776 +119
+ Misses 62096 62049 -47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds missing/required tests for
sqltypes
andmathstats
, and also refactors some existing tests in the packagesRelated Issue(s)
t.Errorf
andt.Fatalf
withassert
andrequire
, respectively #15182Checklist
Deployment Notes