Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemadiff: atomic diffs for range partition DROP PARTITION statement #15843

Merged
merged 2 commits into from
May 8, 2024

Conversation

shlomi-noach
Copy link
Contributor

Description

Introducing a AtomicDiffs() function, which, given a single diff, returns a slice of diffs, as atomic as possible, which together comprises the given diff.

Right now the function only breaks down DROP PARTITION statements.

An an aside, this PR also adds a convenient Clone() function to EntityDiff interface, which does a deep copy of the diff and of its entities (but not necessarily other constructs such as annotations). This is useful for programs using schemadiff as a library as it allows some safety for data manipulation.

Related Issue(s)

Addresses #15842

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels May 6, 2024
@shlomi-noach shlomi-noach requested a review from deepthi as a code owner May 6, 2024 07:55
Copy link
Contributor

vitess-bot bot commented May 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 6, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 6, 2024
@shlomi-noach shlomi-noach requested a review from dbussink May 6, 2024 07:58
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 6, 2024
@shlomi-noach shlomi-noach requested a review from a team May 7, 2024 05:05
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start here and we can further look into what else we want to split up for AtomicDiffs. I suspect there's probably some more cases where it's useful but we can do that in a separate change.

@shlomi-noach shlomi-noach requested a review from a team May 8, 2024 07:47
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 91.35802% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 68.46%. Comparing base (f118ba2) to head (4cb50fc).
Report is 71 commits behind head on main.

Files Patch % Lines
go/vt/schemadiff/table.go 90.24% 4 Missing ⚠️
go/vt/schemadiff/view.go 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15843      +/-   ##
==========================================
+ Coverage   68.40%   68.46%   +0.05%     
==========================================
  Files        1556     1559       +3     
  Lines      195121   196592    +1471     
==========================================
+ Hits       133479   134589    +1110     
- Misses      61642    62003     +361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach merged commit 1c39c52 into vitessio:main May 8, 2024
98 of 105 checks passed
@shlomi-noach shlomi-noach deleted the schemadiff-atomic-diffs branch May 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants