-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update env.sh so that is does not error when running on Mac #15835
Conversation
Signed-off-by: bddicken <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
I would vote for backporting this to previous release branches as people can use the getting started guide / examples from any branch while reading the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this since it works well on my Mac from zsh. But waiting to resolve @mattlord's comment.
Signed-off-by: bddicken <[email protected]>
I apologize for the delay! I guess we missed the backport deadline for the releases earlier this week. Anyways, PR has been updated with the fix recommended my @mattlord. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15835 +/- ##
==========================================
+ Coverage 68.40% 68.43% +0.02%
==========================================
Files 1556 1559 +3
Lines 195121 196825 +1704
==========================================
+ Hits 133479 134702 +1223
- Misses 61642 62123 +481 ☔ View full report in Codecov by Sentry. |
Signed-off-by: bddicken <[email protected]>
Signed-off-by: bddicken <[email protected]>
Signed-off-by: bddicken <[email protected]>
…n Mac (#15835) (#15915) Signed-off-by: bddicken <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…n Mac (#15835) (#15913) Signed-off-by: bddicken <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…n Mac (#15835) (#15914) Signed-off-by: bddicken <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Description
This is a minor fix to
examples/common/env.sh
so that it does not error out on mac wherezsh
is the default shell.shopt
is bash-specific and does not work onzsh
. This fix was suggested by @mattlord while reviewing and discussing this other PR for the docs on the website: vitessio/website#1736This is my first PR to
vitessio/vitess
so not sure about other procedures such as backports, etc.Related Issue(s)
No issue for this.
Checklist