-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTAdmin] Remove vtctld web link, improve local example (#15607) #15824
Merged
notfelineit
merged 2 commits into
vitessio:release-19.0
from
planetscale:cherry-pick-15607-to-19
May 2, 2024
Merged
[VTAdmin] Remove vtctld web link, improve local example (#15607) #15824
notfelineit
merged 2 commits into
vitessio:release-19.0
from
planetscale:cherry-pick-15607-to-19
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notfelineit
requested review from
deepthi,
harshit-gangal,
mattlord and
ajm188
as code owners
May 1, 2024 03:01
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
notfelineit
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
shlomi-noach,
systay,
arthurschreiber,
vmg and
derekperkins
as code owners
May 1, 2024 03:01
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 1, 2024
notfelineit
force-pushed
the
cherry-pick-15607-to-19
branch
from
May 1, 2024 03:02
79dd600
to
0af0297
Compare
Signed-off-by: notfelineit <[email protected]>
notfelineit
changed the title
Cherry pick PR 15607 to v19
[VTAdmin] Remove vtctld web link, improve local example (#15607)
May 1, 2024
deepthi
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
May 1, 2024
deepthi
approved these changes
May 1, 2024
Seems like the code owners on this branch is messed up. There is no need for all the people tagged on this PR to be reviewers. |
mattlord
approved these changes
May 1, 2024
frouioui
approved these changes
May 2, 2024
Signed-off-by: notfelineit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the cherry-pick of #15607
Description
This PR:
vtadmin-up.sh
by 1) outputting the variables that are being set and 2) shortening the wait time for cluster discoveryweb/vtadmin/build.sh
by 1) outputting the variables set and 2) when no hostname is set, uses the local machine's hostnameThe last bullet point made it so that I could run
./101_initial_clusters.sh
without any extra steps, and get vtadmin-web/vtadmin-api working: