-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly unescape keyspace name in FindAllShardsInKeyspace #15765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Apr 21, 2024
mattlord
force-pushed
the
findallshards_backticks
branch
from
April 21, 2024 02:17
cce268b
to
f3912ce
Compare
mattlord
added
Type: Bug
Component: General
Changes throughout the code base
and removed
NeedsWebsiteDocsUpdate
What it says
labels
Apr 21, 2024
This is needed because the input to this function comes from e.g. the vschema, where a keyspace name that contains special characters such as a dash needs to be escaped with backticks. Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
findallshards_backticks
branch
from
April 21, 2024 02:23
f3912ce
to
407c841
Compare
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Apr 21, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
requested review from
ajm188,
deepthi and
rohit-nayak-ps
as code owners
April 21, 2024 02:42
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15765 +/- ##
=======================================
Coverage 68.39% 68.40%
=======================================
Files 1556 1556
Lines 195422 195425 +3
=======================================
+ Hits 133666 133672 +6
+ Misses 61756 61753 -3 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
Apr 23, 2024
I believe this affects us on v19. |
mattlord
added
the
Backport to: release-19.0
Needs to be back ported to release-19.0
label
Apr 23, 2024
frouioui
approved these changes
Apr 23, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Matt Lord <[email protected]>
dbussink
pushed a commit
that referenced
this pull request
Apr 24, 2024
…pace (#15765) (#15786) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: General
Changes throughout the code base
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is needed because the input to this function comes from e.g. the vschema, where a keyspace name that contains special characters such as a dash needs to be SQL escaped with backticks.
I think that we should backport this to v19 as that's when we started making heavier use of this function via #15047 (and #15117).
Related Issue(s)
Checklist